Marfusios/websocket-client

ChannelReader

Odonno opened this issue · 1 comments

Odonno commented

Hello @Marfusios

I am just curious about using and exposing a ChannelReader instead of an Observable to consume received data. I understand the multiple benefits that Rx.NET offers, I only have some questions:

  • Have you tried to make the change already?
  • I am also curious about the performance impact of that change.
  • I suppose it won't have a huge breaking change as you can transform an IAsyncEnumerable into an Observable, still providing the same API experience

Thank you.

Odonno commented

Also curious if we should add .ConfigureAwait(false) here

websocket-client/src/Websocket.Client/WebsocketClient.cs

Line 465 in c002823

result = await client.ReceiveAsync(buffer, token);