MariusAlch/json-to-ts

For optional property, question mark inside key quote instead of outside

Closed this issue · 3 comments

D1no commented

When generating definition files with json-to-ts (either in vs code or directly via the npm module), it puts the question mark for an optional key right inside the key string. Instead of outside of it.

See:

{
'features-CC_LMIV_25-Fanggerätkategorie_tlcm?': string[];
                                   // (..) m?': (..) should be (..) m'?: (..)
}

Shouldn't it be:

'features-CC_LMIV_25-Fanggerätkategorie_tlcm'?: string[];

It should thanks for issue I will try to fix that today.

Fixed with 1.4.3 release. Closing this issue. Again thanks for the issue.

D1no commented

Thanks!