Consider replacing the default favicon for conversion
Closed this issue · 6 comments
Please confirm that you have searched existing issues in the repo
Yes, I have searched the existing issues
Any related issues?
What is the area that this feature belongs to?
Author Usability
Is your feature request related to a problem? Please describe.
The issue was initially brought up in #1866.
The current default favicon on the navigation bar for markbind init --convert is as such:
The concern is that this favicon (on the left) may look like the image has not been fully rendered, when it is in fact working as intended. A better-looking favicon that looks more suitable for MarkBind can replace this (for instance, the default MarkBind favicon on our main page).
Describe the solution you'd like
The current icon being used can be found here. It is a Font Awesome icon for "file image".
We can either replace this with a better looking icon (e.g. house or bars), or with our custom MarkBind icon, as long as it is in line with the theme of our MarkBind default site.
The necessary file to be changed is packages/core/src/Site/siteConvertLayout.njk, in the navbar.
Describe alternatives you've considered
No response
Additional context
No response
Hello, can i work on this?
Hello, can i work on this?
Hi @MrGassner sure!
I can't seem to run the server to check the change, I'm getting 2 errors.
No config file found in parent directories
uncaughtException: The "path" argument must be of type string. Received undefined date
Any guess in what I'm doing wrong?
When using markbind serve -d
I can't seem to run the server to check the change, I'm getting 2 errors.
No config file found in parent directories uncaughtException: The "path" argument must be of type string. Received undefined date
Any guess in what I'm doing wrong?
@MrGassner sounds like you didn't run npm setup. Make sure you did all the steps in the dev guide here :)
Closed with #2389