Please publish latest version of a3700_utils

Question

Please publish latest version of a3700_utils

Closed this issue 4 years ago · 26 comments

Marvell SDK-10.3.5.0-PR1 contains new version of a3700_utils with new patches which are not available in the publically latest branch A3700_utils-armada-18.12-fixed.

Please publish latest version of a3700_utils from Marvell SDK which is currently available only under NDA.

Answer 1 · 2020-12-10T09:37:54.000Z

@kostapr: Could you please look at this issue?

Answer 2 · 2020-12-10T11:12:52.000Z

@pali, let me check if I can legally do it.

Answer 3 · 2020-12-16T12:22:29.000Z

@kostapr: Thanks! Have you find some way how to publish it?

Answer 4 · 2020-12-16T15:32:25.000Z

@pali I just got a green light from my manager. Will push updates shortly

Answer 5 · 2020-12-16T15:54:54.000Z

@pali, please check the new branch. I did not want to destroy the current default one. If it works well, we can make it default.
https://github.com/MarvellEmbeddedProcessors/A3700-utils-marvell/tree/A3700_utils-armada-3.0.0-fixed

Answer 6 · 2020-12-17T18:13:59.000Z

Thank you! I will look at them.

CC @heaterC: You could be interested in new A3700-utils-marvell version too!

Answer 7 · 2020-12-18T17:16:25.000Z

Built an image from this branch but it does not run on my EspressoBin DDR4 1GB 1cs: Board switches to backup U-Boot.

Answer 8 · 2020-12-18T17:56:39.000Z

Seems that in commit 8cb7fbe from A3700_utils-armada-3.0.0-fixed branch is a bug. twin-die combined chip has value 1 and single die(regular) is default and has value 0. Could you therefore try to switch ddr_twin_die_index=1 to ddr_twin_die_index=0 in DDR_TOPOLOGY*.txt files? This looks like a same problem as which we have fixed in MarvellEmbeddedProcessors/mv-ddr-marvell#25 for mv-ddr-marvell repository (as you know without fixing twin-die enum booting have not worked).

Answer 9 · 2020-12-19T13:31:01.000Z

That was it. It's booting now on my device.

Answer 10 · 2020-12-28T21:38:11.000Z

@kostapr: Would you fix this mentioned issue in A3700_utils-armada-3.0.0-fixed branch?

Answer 11 · 2020-12-30T11:15:26.000Z

@pali & @heaterC , our private DDR code still has the twin die enum defined as following:
enum mv_ddr_twin_die {
COMBINED,
NOT_COMBINED,
};
If I fix this this mismatch in A3700 utils here and then get approval of sharing the latest mv_ddr code on Github, it will require additional fix. Maybe it will be better to revert the patch 56db5d1464b44df10a02b99e615ebd6f6a35c428 ?

Answer 12 · 2020-12-30T11:18:58.000Z

Reverting MarvellEmbeddedProcessors/mv-ddr-marvell@56db5d1 commit will lead to unbootable of all A3720 devices when they will use any other version of A3700_utils in this repository and also in other repository forks.

Answer 13 · 2020-12-30T11:30:57.000Z

I see. I pushed the fix

Answer 14 · 2020-12-30T11:38:34.000Z

Thank you!

Answer 15 · 2020-12-31T12:50:39.000Z

@kostapr: Could you create "master" branch which would point to the latest code, so now to the "A3700_utils-armada-3.0.0-fixed" branch?

Because now everytime when new version was released it was required to update steps for building ARM trusted firmeare which complicates things for all projects which are building firmwares for Espressobin and other boards.

If there is classic "master" branch which contains up-to-date code it is not needed to always update instructions how to build ARM trusted firmware and therefore it can simplify whole build setup.

You can still use separate branches like before, just to introduce new master branch which would point to the lastest up-to-date code.

Answer 16 · 2021-01-01T11:25:17.000Z

@pali, done. The master branch is now aligned with A3700_utils-armada-3.0.0-fixed

Answer 17 · 2021-01-01T12:14:49.000Z

Perfect, thank you very much! Can you also set master branch to be repository default branch (and therefore it does not have to be needed to change it again in the furure)?

Answer 18 · 2021-01-01T12:35:01.000Z

I need to ask the project administrator (@haklai) to do so. I do not have permission to change the default project branch.

Answer 19 · 2021-02-06T16:11:19.000Z

@kostapr: I have tested current master branch too and it is working fine for me too!

I have there some changes for A3700-utils-marvell. Should I open a pull request for master branch?

Answer 20 · 2021-02-08T07:34:24.000Z

Hi, @pali, yes, please.

Answer 21 · 2021-03-20T15:25:14.000Z

@kostapr: Could you try to ask for switching base github branch to master where is currently the latest codebase?

Answer 22 · 2021-03-21T08:33:26.000Z

@haklai, could you please set the master branch as a default one?

Answer 23 · 2021-03-22T07:34:04.000Z

I see that default branch for A3700-utils-marvell is now master, thank you very much!

Can you do it also for https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell repository?

Answer 24 · 2021-03-22T07:47:04.000Z

@pali I think we already did this in the past. For this kind of requests you need to ping @haklai since he has the administrator rights on Marvell Github projects

Answer 25 · 2021-03-24T15:11:46.000Z

Default branch for A3700-utils-marvell repository is master as can be seen on page:
https://github.com/MarvellEmbeddedProcessors/A3700-utils-marvell/branches

But default branch for mv-ddr-marvell is not master, so it is not updated, as can be seen on:
https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/branches

@haklai: Could you update default branch also for mv-ddr-marvell to master?

Answer 26 · 2021-04-10T10:49:11.000Z

Now both repositories have master branch as default, thank you very much!