Silkscreen is missing LED polarity
Closed this issue · 12 comments
It might be nice to see the LED polarity shown on the silkscreen for those of us that are sadistic enough to build our own boards.
Also why not show a website address? maslow.cnc 👍
Those are both great suggestions
I'm going to be into the design files working on the schematic for [issue #36(https://github.com//issues/36). I'll open a separate PR to add this and update the board .jpg as well.
Rather than draw an LED symbol, I've put a plus sign opposite the positive end of each of the two LEDs:
If that's satisfactory, I'll put in a PR with the change.
I think that looks great!
There is a small dot on the LED part, does that not indicate polarity?
My read of the schematic is that the polarity should be like this:
Thanks Bar, you're right. Hard to turn my thinking around to 12V power plane and routed ground. The dot does indicate polarity, but I think it wouldn't appear on the silkscreen of a PCB in a maker's hand because it's in a keep-out area. The plus would address that. You've got a good point, though - SMD LED's use a dot to mark the cathode end. How best to address the issue, dot-at-cathode or plus-at-anode? @JDogHerman, what's your opinion?
I think the plus is a great idea! I was just pointing out the dot because I was curious what it meant. You are absolutely right that it does not show up anywhere on the PCB. I actually had an email from the manufacturer this morning to confirm the diode directions so even they are confused 😛
The plus will be much better.
Just to stir the pot, how about:
and
SLICK! I love it
This was addressed in PR#42 - is it Ok to close this?
Also beautifully taken care of. I vote to close.