MatrixAI/js-encryptedfs

unlinkSync does not unlink lower directory

Closed this issue · 2 comments

unlinkSync only unlinks upper directory

we also need to put something in these methods to ensure the file exists in the upperDir before unlinking it. This is causing an error when efs is used in isomorphic-git and since the library doesn't expose the file system errors to the end user, it took a while to realise what was going on. The error happens when isogit tries to unlink removed files in a pull request. I might just submit a quick fix on master and release a new patch to npm. Pretty simple fix.

Fixed with patch 1.0.2