Matt-Esch/virtual-dom

Thunk's count property being considered in dom-index

jgaskins opened this issue · 0 comments

Putting together a quick counter demo, I noticed my "increment" button out of nowhere started decrementing. I noticed when I changed the property name on the thunk component from count to counter, it worked fine, so it had to be something with that property of the component object.

I think I've got it narrowed down to dom-index's recurse function. It seems to be the only place where the count property is checked where it's not being confirmed as a VNode. I figured wrapping an isVNode(vChild) around that might fix it, but I'm not super familiar with the internals, so it's at best an educated guess. :-)

Here's a gist to reproduce it after removing as much noise as I could.