MauroDataMapper/mdm-ui

Compare data model functionality broken

Closed this issue · 3 comments

jelenadreskai commented

Description

Cannot initiate Compare data model functionality

Steps to reproduce

  1. Login as and Administrator or Container Administrator (this may not work for other user types as well)
  2. Select data model in the tree structure, right click and select Compare to Another model
  3. Error is shown to the end user

Expected behavior

Compare UI shows up to the end user

Screenshots

image

Environment

  • Mauro UI [7.1.0]
  • mdm-core [5.1.0]

Additional context

Message Http failure response for http://localhost:8084/api/tree/dataModels/DataModel/c781822f-9b59-4e02-bbb5-cedc17a672d7: 400 OK
Status 400
Path http://localhost:8084/api/tree/dataModels/DataModel/c781822f-9b59-4e02-bbb5-cedc17a672d7

GBishop-PHSA commented

@olliefreeman We're seeing in the logs that the TreeInterceptor fails because of the uncommented code that throws the exception. (mc-9800)

The request is:
[GET] /api/tree/dataModels/DataModel/
Where the model uuid is for a draft data model.

Is the UI supposed to be calling a different url to build the tree when using the compare function?

olliefreeman commented

moving this to the ui, as the UI is using the wrong endpoint.
It should be

api/tree/$containerDomainType/$catalogueItemDomainType/$catalogueItemId

pjmonks commented

The incorrect endpoint was indeed used, this has been fixed now.