MauroDataMapper/mdm-ui

Terminology and Code Set search covers full catalogue

Opened this issue · 2 comments

Description

As noted in #571, the Mauro backend does not seem to provide a dedicated endpoint to search terminologies or code sets. Something can be submitted but it is not restricted by the root terminology/codeset, instead it searches the entire catalogue.

Steps to reproduce

Send a request to either POST /api/terminologies/{id}/search or POST /api/codeSets/{id}/search with a search payload that seems relevant to those models e.g. search term could be for a term label.

A 200 response if returned, but the search results relate to anything in the catalogue, such as Data Models, Data Types etc, which are not in the same domain.

Expected behavior

Terminology and Code Set search should be restricted to only searching and returning Terms.

Commit 3899327 fixed the search service for terminologies to use the endpoint POST /api/terminologies/{id}/terms/search

Discussing with @aaronforshaw , he believes that this issue is now resolved for Terminologies thanks to PR #622 . What remains is to decide if searching Code Sets are a requirement, which may then require a new endpoint and other small UI changes.