Maximetinu/Sublime-Text-Monokai-theme-for-Visual-Studio-Code

Set transparency to colors

tomasts248 opened this issue · 4 comments

tomasts248 commented

Hi, I noticed the colors are the same except sublimetext uses a subtle transparency that are better for continued eye sight. Can transparency be added to match better the colors in this regard?
Have a nice weekend!

Maximetinu commented

Hi. Sorry, I never understood your request. It's been 3 years since this, so I'm closing this issue. Feel free to post it again with some screenshots as examples! 😄

tomasts248 commented

You should had asked?
Well easy:
image
left side is VSCode Studio with your plugin and right Sublime Text you may notice on the first, the text color is brighter

Maximetinu commented

Sorry, but I cannot differentiate between both sides of the screenshot. Maybe my screen or even my eyes don't catch the subtle difference 😋 However I checked it with a color picker and you're right, is slightly different. I think that the right side colors are slightly darker, isn't it? You're right it could be due to some kind of transparency on the Sublime's palette.

The sublime red/pink I'm using is: #f92672

image

I've seen different variations of it, for example at:

https://gist.github.com/r-malon/8fc669332215c8028697a0bbfbfbb32a

it stands for: #b05279

For this theme I used the default VS Code Monokai colors thinking that they were the same as Sublime's. However, after checking Sublime's internal files I've found that it uses #F92472 for red/pink, which differs slightly from the one I'm using. Maybe that's the reason for the colors differences.

I guess that if this theme is an "Identical" copy of Sublime's, it should also match it in these subtle things. So thanks for reporting it!

I'm reopening the issue and will look at it more closely in the future. For now I have no time to look at it, but it'll remain open for people to investigate it further and open a PR 😃

tomastestart commented

So thanks for reporting it!

Thank you for taking a look into it!

I'm reopening the issue and will look at it more closely in the future. For now I have no time to look at it, but it'll remain open for people to investigate it further and open a PR smiley

Okey! ;)