Consider porting nymphcast-player to QML
PureTryOut opened this issue · 5 comments
Since I'm a postmarketOS developer, I have an interest of using NymphCast on Linux (non-Android) phones. The Nymphcast Player could work great here, if it's UI were made responsive using QML and possibly some responsive library like KDE's Kirigami2.
Currently the experience is... Less than optimal. Apologies for the bad picture, but see how it looks on the PinePhone:
I have reduced the minimum sizes for the Player window, which should at least help with making it fit better on smaller screens. Minimum width is now 360 px, which assuming 2x scaling on the 720p display on the PinePhone should make it fit properly.
As for making the Player UI work better across resolutions, this is something that definitely needs looking at. There are ways to make the current layout into a flow layout: https://doc.qt.io/qt-5/qtwidgets-layouts-flowlayout-example.html
Styling the standard widgets using stylesheets will also allow for them to fit better on a specific platform. https://doc.qt.io/Qt-5/stylesheet-syntax.html
Stylesheet support is now available in the Player. By default default.css in the binary folder will be used. I have pushed a simple stylesheet for now that changes the color of the window and changes the size of the tabs.
The location of the stylesheet file is set in the registry (on Windows) or its equivalent (per the Qt documentation). The idea is to have different stylesheets for different target platforms that can style the GUI for that platform.
Work on a QML-based version of the NC Player has begun. This version will exist parallel with the current Qt Widget version, and share most of the code. This will leave users free to pick the version that works best for them.
I expect to have updates on the progress by next month.