Mazamars312/Analogue-Amiga

`shortname` casing different from folder casing

Closed this issue · 8 comments

Hi,

Great work on the core (again)

One thing is tripping up Pocket Sync a little:

The core folder name should follow this convention: AuthorName.CoreName where AuthorName and CoreName correspond to author and shortname in core.json respectively.

https://www.analogue.co/developer/docs/core-definition-files#folder-naming-convention

The folder ends up as Mazamars312.Amiga vs amiga in the shortname field

Fair call. This is why I at times, "hate" Unix/Linux file systems. Windows make this too easy. LOL

Ill work on this on the next build and test on the next build 0.0.6. If you hit me up on discord I can get a 'pre' release done first so you can test

Thanks for fixing. As someone who stages on Linux before pushing to sdcard/exfat, these kind of bugs are equally frustrating for us. 🤷‍♂️

I can create a pull request to rename Analogue-Amiga/dist/assets/ to Analogue-Amiga/dist/Assets/ and the same for .../platforms to .../Platforms. But this will probably require you to manually do a two-step on Windows:

move assets Assets2
move Assets2 Assets
move platforms Platforms2
move Platforms2 Platforms

Would you like me to send the request?

I can change the folders in the next build. It would tho require some people to check their folders.

Could you please check for me (BTW I have made the Amiga name in my core name with a capital as well)
image
image
image
image
image
image

Yes, the way those folders are capitalised matches mine.

Sweet, I have this already to go shortly once I have the Floppy controller speed up stuff done

Been released now

I’ve started putting together a validator that’ll catch this sort of thing: https://github.com/neil-morrison44/openfpga-validator

(It’s pretty barebones at the moment but I’ll be adding more checks)