Create CompatSlotItemHandler

Question

Create CompatSlotItemHandler

Closed this issue 8 years ago · 5 comments

I'd like to see a new class, mcjty.lib.compat.CompatSlotItemHandler, which extends net.minecraftforge.items.SlotItemHandler, and implements getX, getY, setX, setY, onTake, and onPickup for it.

I'm working with CompatLayer, and attempting to reimplement my class extending SlotItemHandler. However, I use onTake (which is not a method in 1.10.2) and to use CompatSlot I would have to re-implement all the logic in Forge's SlotItemHandler.

Answer 1 · 2017-03-06T10:52:25.000Z

I can't find an onTake() in 1.11 either? What onTake do you mean?

Answer 2 · 2017-03-06T16:37:29.000Z

net.minecraft.inventory.Slot#onTake(EntityPlayer thePlayer, ItemStack stack)
I am on Forge 1.11.2-13-20.0.2252.

Answer 3 · 2017-03-10T07:22:49.000Z

Sorry for the delay. Will try to deal with this later today if I find the time

Answer 4 · 2017-03-10T15:10:05.000Z

Ok, working on this. Note that only onTake is needed as CompatSlot.getX also works on SlotItemHandler

Answer 5 · 2017-03-10T15:12:43.000Z

Fixed next release (hopefully later)