Melkeydev/go-blueprint

[Bug] Docker-compose command is incorrect

Closed this issue · 3 comments

What is the problem?

There is an error in the make docker-* commands.

Both commands currently have:

docker compose

this should be:

docker-compose

no need to check for version of docker-compose.

docker-compose up and docker-compose down works for all versions of docker.

Operating System

windows 10

Architecture Version (x86, x64, arm, etc)

x86

Steps to reproduce

run make docker-run

Relevant log output

make docker-run 
compose was unexpected at this time.
make: *** [Makefile:19: docker-run] Error 255

If you are using the latest version of docker, you can install docker compose as a plugin, instructions and you will run docker compose up. But if you are using a slightly older version of docker and using the docker-compose executable, you will need to run docker-compose up. So it depends on your current version of docker and docker compose. Hope that helps.

Docker make commands are only for Unix-like systems, they would not work on Windows. Maybe we can update the make templating to include Windows support as well.

# Create DB container
docker-run:
	@docker compose up

# Shutdown DB container
docker-down:
	@docker compose down

Resolved in #306