Mellanox/mstflint

mstlink doesn't build if system libjson-c-dev installed

dannf opened this issue · 1 comments

dannf commented

mstlink builds fine when using the internal libjson - but if a system one is installed, it fails. As seen on Debian/unstable:

$ ./autogen.sh && ./configure --enable-adb-generic-tools && make -j$(nproc)

[...]

Making all in mlxlink
make[2]: Entering directory '/tmp/mstflint/mlxlink'
 cd .. && /bin/bash /tmp/mstflint/config/missing automake-1.16 --foreign mlxlink/Makefile
mlxlink/Makefile.am:49: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
 cd .. && /bin/bash ./config.status mlxlink/Makefile depfiles
config.status: creating mlxlink/Makefile
config.status: executing depfiles commands
Making all in modules
make[3]: Entering directory '/tmp/mstflint/mlxlink/modules'
Making all in printutil
make[4]: Entering directory '/tmp/mstflint/mlxlink/modules/printutil'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/tmp/mstflint/mlxlink/modules/printutil'
make[4]: Entering directory '/tmp/mstflint/mlxlink/modules'
make[4]: *** No rule to make target '../../ext_libs/json/libjson.a', needed by 'libmodules_lib.a'.  Stop.
make[4]: Leaving directory '/tmp/mstflint/mlxlink/modules'
make[3]: *** [Makefile:603: all-recursive] Error 1
make[3]: Leaving directory '/tmp/mstflint/mlxlink/modules'
make[2]: *** [Makefile:599: all-recursive] Error 1
make[2]: Leaving directory '/tmp/mstflint/mlxlink'
make[1]: *** [Makefile:545: all-recursive] Error 1
make[1]: Leaving directory '/tmp/mstflint'
make: *** [Makefile:432: all] Error 2

Commit e435d15 fixes this issue. This commit is part of release v4.15.0-1.