nv_dma_unmap() is not protected by nv_mem_context->is_callback

Question

nv_dma_unmap() is not protected by nv_mem_context->is_callback

drossetti opened this issue 7 years ago · 8 comments

in nv_dma_unmap(), if NV_DMA_MAPPING is defined, nvidia_p2p_dma_unmap_pages is called, which frees dma_mapping, even without setting nv_mem_context->sg_allocated.

later in nv_mem_put_pages(), sg_free_table() is called if nv_mem_context->sg_allocated!=0, even if NV_DMA_MAPPING is defined, which is incorrect.

ferasd commented 7 years ago

#16

ferasd commented 7 years ago

#20

drossetti commented 7 years ago

closing

Answer 1 · 2017-04-27T19:00:56.000Z

I propose to have the call to sg_free_table() protected by NV_DMA_MAPPING==0

Answer 2 · 2017-04-27T19:21:45.000Z

looking better, the call to sg_free_table() is always need.

but nv_dma_unmap() is not protected by nv_mem_context->is_callback, as in nv_mem_put_pages().

Answer 3 · 2017-04-27T19:22:13.000Z

changing synopsis

Answer 4 · 2017-04-27T19:25:06.000Z

minor issue, nv_mem_put_pages does not set sg_allocated = 0

Answer 5 · 2017-04-30T16:32:42.000Z

Right, sg_free_table should be called always since sg_head is allocated in both cases.
nv_mem_context->is_callback protection fix will be pushed.