MenuDocs/Pyro

Add black app to immediately disable PRs if black formatting isnt followed

ribosomerocker opened this issue · 6 comments

ribosomerocker commented

Add a black python formatting integration to check for black styling and fix stuff, as well as stop merges if black is not ran on them

Skelmis commented

Could we take this a step further in that any code committed that doesn't follow black formatting is automatically changed?

  • 👍1
Skelmis commented

Could use something such as a pre-commit thing, see the bottom of this
https://www.mattlayman.com/blog/2018/python-code-black/

ribosomerocker commented

Yes, thank you!

ribosomerocker commented

@Skelmis Can you implement this feature and close this issue once its good? I'll be checking the new commits in the db integration branch

Skelmis commented

Ill take a geez and attempt to implement in the morning sure thing

Skelmis commented

For everyone, I need you to do the following.
pip install pre-commit

Then in git bash run pre-commit install