[New Snap] Rubic - BestRateFinder
Closed this issue · 1 comments
mario-christopher commented
Checklist
All items in the list below needs to be satisfied.
- Is the Snap repository publicly accessible and linked in this ticket? https://github.com/Cryptorubic/rubic-snap-frontend
- Is the Snap distributed on npm and linked in this ticket? https://www.npmjs.com/package/rubic-snap
- Has an audit been performed and the audit report attached or linked in this issue? https://cure53.de/pentest-report_rubic-snap.pdf
- Is a complete list of discovered vulnerabilities from the audit documented in this issue?
- For vulnerabilities that have been deemed necessary to be addressed, are the links to the fixes attached to this issue?
- For vulnerabilities that have been deemed not necessary to be addressed, is a reason for each of them documented in this issue?
- The corresponding pull request in this repo has been merged.
mario-christopher commented
Audit Findings:
- Imprecise ETH address validation [Fixed]
Note from the builder: Please don't publish the snap until we settle the PR issues, let's coordinate the date
So there is no category added for the Snap in the registry. The builder is ok with allowListing and not displaying the snap in the Directory.
Version to be allowlisted: 0.4.0