[Feature Request]: Add year to ZIP files
insurw opened this issue · 6 comments
Confirmations
- I confirm that I checked the issues tab and couldn't find an existing issue with a request for the feature I want to requst.
Description
If ripped individually the subtitles will always have a year in the title. Same for the subtitles in the ZIPs.
I think the ZIP files will only have year if the iTunes URL contains it. iTunes isn't consistent in having a year in URL for movies to avoid name collisions.
Example:
https://itunes.apple.com/se/movie/pinocchio/id540283464?l=en
https://itunes.apple.com/se/movie/pinocchio/id1597469980?l=en
Thanks for the suggestion.
Added in the latest release (v2.3.3).
Thanks for the suggestion. Added in the latest release (v2.3.3).
Thanks! Though I found a small issue when the movie title contains the year. You'll get double years, in both the ZIP and the VTT files, but it's not really that important. It's more important having the year in the ZIP file name.
iTunes kinda sucks regarding the year data. The year on the movie page seems to sometimes be the region's release date (or digital release maybe?). So you get silly things like "Fantasia (1940)" having a release date of 1990. So in a way it's good to have double years, but it's kinda annoying with the same year twice.
They aren't consistent with year in title. It's mostly used differentiate movies from the 2010s/1990s from movies in 1950+
You can get e.g. The Third Man from 1949 with a release date of 2015. The.Third.Man.2015.iT.WEB.zip
https://itunes.apple.com/se/movie/the-third-man/id1490947650?l=en
Cinderella.1950.1950.iT.WEB
https://itunes.apple.com/se/movie/cinderella-1950/id1339827782?l=en
Dumbo.1941.1946.iT.WEB
https://itunes.apple.com/se/movie/dumbo-1941/id1338970937?l=en
Fantasia.1940.1990.iT.WEB
https://itunes.apple.com/se/movie/fantasia-1940/id1429270511?l=en
I checked a few movies. If you scraped copyright instead of released year you'd get the correct year. Though not all movies have the copyright year. So maybe switch to copyright year and have released year as fallback, but even copyright year won't always be correct, e.g.
https://itunes.apple.com/se/movie/superman-batman-apocalypse/id820997757?l=en
But better that it's now with a lot of old movies having wrong year.
Thanks for reporting.
I've pushed a fix (6a0bc2d) for cases where thesame year is already in the title (like Cinderella.1950.1950.iT.WEB).
I actually had this in mind while working on the fix for this issue, but I forgot to implement it.
As for cases where the year in title and the release year on the metadata mismatch, it will remain as it currently is (like Dumbo.1941.1946.iT.WEB for example) for now, as I don't have a simple solution in mind at the moment.
The original release year like (1941 in Dumbo's case) should be the correct one, but taking the release year from the title is problematic as it could be part of the title (for example: "2012" and "1917" are both movie names).
Using the copyright is not reliable enough.
I'll keep that in mind though and see if I can find a solution.
Using the copyright is not reliable enough.
How so? That it's available or accuracy?
I checked copyright year for a few iTunes movies on US store and they seem to be correct. One was off by one year.
I've done 1.4k rips on the Swedish store. I'd say about 1/3-1/4 have incorrect year using released. A lot of them are off by 1-2 year (because of Swedish region released date) but a lot also have decades in difference.
@MichaelYochpaz I checked a few more movies (Swedish store) and a lot them have released year one year later than copyright year. "Copyright year" is what IMDB, TMDB, Wikipedia have. IMO released year is what's not reliable.
If you only look at the US store I guess you could say the few times it's incorrect makes it "unreliable".
In the Swedish store (and probably other languages) the year is wrong a lot.
There are probably a lot more than I've noticed. It's easy to miss 1-2 years off the correct year for movies you haven't memorized.