MichaelYochpaz/iSubRip

[Issue]: No matching subtitles found

williameyelash opened this issue · 11 comments

williameyelash commented

Confirmations

  • I have checked the issues tab, and couldn't find an existing open issue for the issue I want to report.

OS Type

Windows

Python Version

3.11.1

Package Version

2.4.0

Description

https://tv.apple.com/fi/movie/goldstone/umc.cmc.5up0cp30rbmrod9hc1xjq86o3?playableId=tvs.sbd.9001%3A1501840635

"No matching subtitles found". Worked just fine with the previous version.

Config

No response

Output Log

No response

MichaelYochpaz commented

Hey, works fine for me.

Scraping https://tv.apple.com/fi/movie/goldstone/umc.cmc.5up0cp30rbmrod9hc1xjq86o3?playableId=tvs.sbd.9001%3A1501840635
Found movie: Goldstone (2017)
dansk (da) subtitles were successfully downloaded.
Suomi (fi) subtitles were successfully downloaded.
norsk (no) subtitles were successfully downloaded.
Svenska (sv) subtitles were successfully downloaded.

4/4 matching subtitles have been successfully downloaded.

Are you sure you don't have a config file in use?
You might have a filter for languages that don't include any of these 4.
Also, probably not related to this issue, but there has been a 2.4.1 release with some bugfixes you should upgrade to.

williameyelash commented

Hm, no, I just upgraded via command line and that's it. Uninstalled it now and installed again -- same problem.

williameyelash commented

Went back to 2.3.3 and it works fine for me.

MichaelYochpaz commented

I'm going to need some additional information as I'm unable to reproduce this issue.

  1. Add the complete output when using v2.4.1 on the same URL (like the one I sent here).
  2. Does this issue reproduce when downloading other content after the update? Or just this specific movie?
  3. Run isubrip https://tv.apple.com/ca/movie/living/umc.cmc.7jo8l4dfds2vupar7bidbklbe and add the complete output (I want to see if it filters any specific languages, and if it does, which ones).
  4. Create the following config on %USERPROFILE%\.isubrip\config.toml (since you don't have one, you'll have to create a new file): 
    [downloads]
languages = []
    Run the command again (on v2.4.1), and add the complete output of that as well.
  5. Visit the following playlist link, download it, and attach it (rename it to a .txt extension if GitHub doesn't allow uploading m3u8 formats. Or alternatively, upload it to pastebin and post a link).
    I want to check if you're receiving a different playlist file than I do for some reason (perhaps geolocation)
williameyelash commented
  1. Scraping https://tv.apple.com/fi/movie/goldstone/umc.cmc.5up0cp30rbmrod9hc1xjq86o3?playableId=tvs.sbd.9001%3A1501840635
    Found movie: Goldstone (2017)
    No matching subtitles were found.

It then creates a .zip file with the size of 1 KB that you can't unzip, it says "No files to extract"
2. No, it's relevant for all links.
3. Scraping https://tv.apple.com/ca/movie/living/umc.cmc.7jo8l4dfds2vupar7bidbklbe
Found movie: Living (2023)
No matching subtitles were found.
4. Scraping https://tv.apple.com/ca/movie/living/umc.cmc.7jo8l4dfds2vupar7bidbklbe
Found movie: Living (2023)
No matching subtitles were found.
5. https://pastebin.com/RbQZ2sN2

MichaelYochpaz commented

I've created a new branch with logs to allow me to further investigate this issue.

Please run python3 -m pip install -e git+https://github.com/MichaelYochpaz/iSubRip.git@issue-43-logs#egg=isubrip to install it, then rerun the command (isubrip https://tv.apple.com/fi/movie/goldstone/umc.cmc.5up0cp30rbmrod9hc1xjq86o3?playableId=tvs.sbd.9001%3A1501840635) and send me the output (you should see a bunch of LOG: lines prints)

Also, please add it in a formatted-code format as it should be a somewhat-long output, and GitHub might mess it up if you don't.
Paste it in-between triple backticks, like the following example:

```
< Logs go here >
```

A pastebin is also fine.

After that, you can uninstall iSubRip and reinstall it normally to return to the base version without the logs.

MichaelYochpaz commented

Thanks for the logs.
There seems to be a small section of code where errors are being suppressed, which is why it was hard to track down up to this point (no error was raised).

I've fixed that on the debug branch (I will also update that on main for the next version release), please rerun the pip installation command to update it:

python3 -m pip install -e git+https://github.com/MichaelYochpaz/iSubRip.git@issue-43-logs#egg=isubrip`

And then rerun the iSubRip command and send me the new logs (hopefully for the last time).

Looking at the relevant code section that was suppressed, I suspect this issue might be path related (this section generates a file name, and saves the subtitles to disk on a temp folder), so you could also try running the command on a different location (for example C:\Test), or set a path in the config and see if the behavior changes.

Sorry for all the hassle.

williameyelash commented

Here you go: https://pastebin.com/LQy2kHvk

Set a different path in the config.toml that's in Users\Username.isubrip but nothing changed.

I wonder if anyone else is having this issue.

MichaelYochpaz commented

Thanks again for the logs.
I was finally able to find out what caused this issue, and successfully reproduce it :)

It's caused by a bug on Python version 3.11.1, that was later fixed on version 3.11.2 (this is from the changelog):

gh-100098: Fix tuple subclasses being cast to tuple when used as enum values.

I've been using Python 3.11.3 which is why I couldn't reproduce it.
I've installed 3.11.1 (the version you're using), and the error reproduced.

So basically, if you'll update your Python version (or downgrade it) this should be resolved.
I'm leaving the issue open, please report back if you were able to fix it.

williameyelash commented

Works fine now, thanks!

  • 🎉1