MichaelYochpaz/iSubRip

[Issue]: whenever isubrip finds a subtitles file, python crashes.

Closed this issue · 4 comments

yoavoffek commented

Confirmations

  • I have checked the issues tab, and couldn't find an existing open issue for the issue I want to report.

OS Type

Windows

Python Version

3.11.4

Package Version

2.4.3

Description

whenever I try to download any subtitle to any path that's not the isubrip folder, and isubrip does indeed find a subtitles file, as soon as it does, python crashes.
I've tried debugging this problem, steps included running isubrip on a different computer (on which it worked perfectly). completely uninstalling and purging all libraries and modules, then reinstalling everything (which did not work). downgrading to an older version of python.
nothing seems to work.

when debugging, I came across an error that seemed to indicate that this is a permissions error, and so I tried to run isubrip as admin, but still I keep on getting the same error.

the odd thing is that when I hit "close program" on the "python has crashed" window that gets prompted, isubrip does indeed download the desired subtitle to the folder specified in the config file.
I've been trying to debug this for the past two weeks to no avail, which is why I'm now submitting this report.

just to clarify, I'm using the administrator user of said computer (so there shouldn't be and read/write permission problems), and cmd is running on either admin or system permissions, yet still python crashes on both.

when debugging, this is the error I got:
Unhandled exception at 0x00007FF8EE9CBA44 (python311.dll) in python.exe: 0xC0000005: Access violation reading location 0x0000000000000008.

Output Log

Scraping https://tv.apple.com/il/movie/the-little-mermaid/umc.cmc.gto5t9phvu7dpajarqglrfmh
Found movie: The Little Mermaid (2023)
עברית (he) subtitles were successfully downloaded.
עברית (forced) (he) subtitles were successfully downloaded.

2/2 matching subtitles have been successfully downloaded.

#then after that python crashes, and displays the subtitles in the folder, only after I press "close program", as stated in the description.

Config

[general]
check-for-updates = true

[downloads]
folder = "C:\\Users\\Administrator\\Documents\\ATV-Downloads"
format = "srt"
languages = [
    "he",
    "he-IL",
]
overwrite-existing = true
merge-playlists = false
zip = false

[subtitles]
remove-duplicates = true
convert-to-srt = true

[scrapers]
user-agent = "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36"
MichaelYochpaz commented

Hey,
First off, for next time, please just upload the image to the issue instead of sending a link to a 3rd-party site that starts downloading a file that I have to verify isn't malicious. You can just drag & drop an image file into the comment body. If the image is too large, you can just remove the image tags surrounding the generated link and send it as such:
https://github.com/MichaelYochpaz/iSubRip/assets/8832013/e66b288a-cd4e-4b78-bdc2-dfd69cab8d39

As for the issue - are you running iSubRip from the command line or from another Python script?
The original issue seems to indicate that you are running it normally, but in the screenshot it seems like you're trying to import and use a specific module (scraper) from the code, which won't work if not done properly.

These seem like two different issues with two different errors.

yoavoffek commented

In the image, I was indeed trying to run it through a different script that calls iSubRip, however, the problem is present both when attempting to call just iSubRip, and when trying to call it through the script.

For the sake of your help, let's just ignore the script part, as that might be a bug on my end, and not on iSubRip's end.

The error I'm getting when debugging the crash of python, is the one sent in the original post, which seems to indicate some sort of permissions problem, which does not make any sense...

MichaelYochpaz commented

Closing, as this issue doesn't reproduce and there aren't any complaints by others for a similar issue.
Probably an issue with the Python installation / packages on your computer.