MightyCreak/mesamatrix

Spell out anvil, lavapipe, turnip and venus, instead of anv, lvp, tu & vn

Opened this issue · 8 comments

Olf0 commented

Suggestion

Please spell out anvil, lavapipe, turnip and venus in the leaderboard tables and the big tables, instead of using anv, lvp, tu and vn.

Reasons

  • The abbreviations anv, lvp, tu and vn are not widely used and known, hence displaying them in the user visible part of mesamatrix (i.e., its generated web page) contradicts its very purpose:
    To inform concisely about the current API implementation state of various MESA drivers.

  • They are already spelled out in the commit messages listed in the section "Last commits"!
    Hence confusingly two different names are used in the generated mesamatrix page for references to these MESA drivers:

    • anvil versus anv
    • lavapipe versus lvp
    • turnip versus tu
    • venus versus vn
Olf0 commented

Side note

Because I am not fluent in PHP, I am not sure, if it is sufficient to alter these Vulkan driver names here:
https://github.com/MightyCreak/mesamatrix/blob/master/lib/Parser/Constants.php#L71

MightyCreak commented

To implement your suggestion, you'll need to create an abstraction between the current drivers names and the long names. This is because the current names are used to parse the features.txt file, so we'll still need them.

Olf0 commented

Well, in theory this is an MESA issue, as the aforementioned "reason 2" / inconsistency shows: The MESA authors usually spell out these three Vulkan driver names in their commit messages, but these drivers' "real" names in the repository are in the abbreviated form (which is hardly recognisable in the case of tu and lvp).

Still I think it would serve the very purpose of mesamatrix well to rectify this flaw (see "reason 1").

MightyCreak commented

I agree with you that we could do something about it. I'm just saying that we can't simply change the Constants.php file because the contents of features.txt only use the abbreviated names (my algorithm doesn't use the commit description to feed the table).

  • 👍1
Olf0 commented

Thank you.
This was my primary aim: To create awareness of this.
Side note: By the help of your explanation and my little understanding of PHP, I now see, that this needs some workaround, e.g. with a look-up table and a function using it to translate these strings.

  • 👍1
Olf0 commented

Updated to include venus / vn.

Olf0 commented

Note that issue #212 provides the (hopefully) correct spelling for all drivers in their unabbreviated form.

Whoever implements this (whenever), please utilise that list, because some of the spellings are ambiguous and for some multiple variants are used: It took surprisingly much effort to determine the authentic spelling for each driver.

okias commented

Please, AT LEAST provide note somewhere into bottom of page, so we can use shortcuts as CTRL-F to find it.

I work on Mesa, so I know lvp shortcut, but when I wanted to check turnip features, I REALLY didn't associated it with tu when using combo as CTRL-F turnip.

  • 👍1