Wrong return type of decimalPlaces()

Question

Wrong return type of decimalPlaces()

pobch opened this issue 3 years ago · 3 comments

According to the doc:

If dp is omitted, or is null or undefined, the return value is the number of decimal places of the value of this BigNumber, or null if the value of this BigNumber is ±Infinity or NaN

By the way, the return type of decimalPlaces() is just number, which is wrong. The correct type should be number | null.

Answer 1 · 2022-02-13T23:04:15.000Z

Thank you for letting me know.

Answer 2 · 2023-01-09T20:30:11.000Z

Got the same issue +1 Was wondering which version can resolve the issue. Thx.

Answer 3 · 2023-01-10T18:25:47.000Z

@lukelu0520

I'm sure you can find that out for yourself.