MikeSiLVO/script.skinshortcuts

WidgetTarget Empty for Playlists

Closed this issue · 3 comments

@anxdpanic Perhaps you may be able to assist.

In troubleshooting why some widgets now seem to be broken for my skin, I noticed that the widgetTarget is coming back empty. I traced the changed behavior down to: 12562d2#diff-3eb7af7688749ce58a2bcec5231231baf7ed546fc81f4f2c9426ba1bc5eefc3bR1157 . The media_content is being set to an empty string on each line iteration of the xsp parsing. This causes the variable to be blanked out before it is read for the line.tag=="name" check happens. I am not sure why the media_content variable needs to be set to an empty string, but the media_library does not, but I believe the code needs to be changed to something like:

                        for line in iterator:

                            if line.tag == "smartplaylist":
                                media_content = ""

around line 1251 in library.py

This change causes the media_content (and therefore the widgetTarget) to get set correctly.

Should be resolved in #76 , thank you!
Will try to get a test zip up soon

Can you give, https://github.com/mikesilvo164/script.skinshortcuts/releases/tag/2.0.1.alpha1 a try and confirm the issue is resolved when you have some time. Thanks, in advance.

Looks good to me. Thanks for the quick update!