MineMaarten/Signals

Cart Hopper emits even if there's still 'activity'

Sewef opened this issue · 2 comments

Sewef commented

Forge 14.23.5.2837
Signals 1.4.1-30
Playing on dedicated server.

Here's the setup :
2019-06-15_11 49 15
Cargo Manager (Steve's Carts) filled with items → Omnidirectionnal Hopper (PNC) full too → Cart Hopper

As soon as I set the Cart Hopper to 'Emit when no activity', it will send out the cart event if the Omni hopper is full and is transfering items.

The 'Emit when no activity' unfortunately looks only at the 'activity' the Cart Hopper itself initiates. So for example when an inventory is placed on top of the Cart Hopper, and the items are transported to the cart by the Cart Hopper.

It might be a good feature to also make it work with externally transported items, but I'd prefer it could be a generic addition (that it automatically works for items, fluids, ... in one go).

I made a small fix, but it may not be pretty: GsakuL/Signals@f7b1488
Each Capability (Item/Fluid/...) has it's own methods. Thus a mixin would be needed