MinecraftForge/FML

Substitution - IDs not being synced properly

master801 opened this issue · 17 comments

Minecraft version: 1.7.10
FML and Forge version: 7.10.88.1307-1.7.10

Registering code: https://github.com/master801/betterAnvil-forge/blob/master/src/main/java/vdvman1/betterAnvil/BetterAnvil.java#L91

Client log when logging into a server: http://pastebin.com/vRDGTqBx

Some of its content were cut short due to Pastebin's size limit.
Note, this is purely only with FML, Forge and my custom build of a mod.

cpw commented

Without log files, it's very hard to comprehend what FML does here. It logs every action it takes, so my suggestion is to capture log files from an erroring session.

Unfortunately, there's a lot of mods that "think they know better" and directly futz with the registry, so it's possible this isn't FML, but rather hacky interference from something else.

But, please, log files are the start...

cpw commented

Also, please file a separate issue for the texture problem- I can't track both in one issue. Again, log files, and screenshots demonstrating what's going wrong, would be helpful here.

Will do

EDIT: Working on that right now...

EDIT EDIT: Texture registering issue is here: #618

cpw commented

Thanks for the log file. It seems that your substitution isn't working properly. Can you explain the setup for the log file. Were you connecting to a dedicated server? It doesn't look like a single player game.

Yes I was using a dedicated server. Should I try running it on a lan server too?

cpw commented

OK. I'm going to try and recreate in a dedicated server environment. I thought I had this tested...

Here's a download link to the mod I'm using, if you want.

http://www.mediafire.com/download/qs9uruagcn6n7uu/BetterAnvil-3.1.7-C.jar

cpw commented

One further request - have you tried moving your substitution to the PreInit event?
This goes for both issues..

Hmmm... that shouldn't matter, but I'll give it a go later.

cpw commented

It might - preinit comes before any assets are loaded, init comes after the first loading round..

Alright, I tried moving the subsitution registration into pre-initialisation for both, and they both failed like before.

cpw commented

OK, for the anvil not working on a dedi server, try the new FML build above. I'll merge into forge shortly but this fixes my local test mod.

I'll test that in a bit.

cpw commented

Forge #1342 should do the trick... If it does, I'll leave this issue until I merge the fix on the mainline, but enjoy ;) Update if you encounter further issues.

BTW: required-after:Forge@[10.13.2.1342,11] should force the right dependency.

Thanks for the issue report..

Thank you for fixing it, cpw.

I'll reopen this issue if I have any problems with it.

cpw commented

Needs fixing in 1.8 as well..

Sorry about that, forgot about 1.8...

Thank you cpw, for fixing it!