net.minecraft.world.Blockreader -> net.minecraft.world.FixedBlockReader
sciwhiz12 opened this issue · 2 comments
Missing upper camel case. It might be worth thinking renaming this to something like FixedBlockReader, since it only gives out BlockStates according to a final array.
It looks to be more like only reading a Y-column of a x/z position. As the input BlockState-array is interpreted as such.
Edit: Screenshot taken from net.minecraft.world.Blockreader L22-24
So i'm not sure "BlockReader" itself might be a fitting naming as it'd suggest a generic implementation of IBlockReader which it definitely is not.
I opened the issue as BlockReader because I just corrected the name to use PascalCase/UpperCamelCase. I agree that it should be renamed to better fit how it works; and my suggestion is FixedBlockReader, since it gives BlockStates according to a fixed, final array. Should I rename the issue?