Suggestion: Configurable lunar cycle
Sunconure11 opened this issue · 16 comments
Lately I've been noticing in my modpack that the moon is always invisible. I am using Dynamic Surroundings and Hardcore Darkness, if those two mods could be doing this.
Can you give me the screenshot?
It might be an issue with Dynamic Surroundings, as removing one or the other stops it, but, I'll take screencaps anyways.
I also reported this issue to the dev of the other mod, and I'm going to see if his config changes do anything first.
His settings didn't work, so, here are screencaps of the world, to the best of my abilities:
https://www.dropbox.com/sh/2q0sw142bye67wd/AADM1HUmbUvezapZG39OCA9Qa?dl=0
This appears to be a user error. The moon has finally shown itself. It might be related to the config changes though.
However, could you get the moon cycle to be more in sync with vanilla, or at least, have an option to do so? It has some weird issues with other mods (I.E Hardcore Darkness becomes super pitch black during a full moon, and I am sure it screws with Witchery):
https://www.dropbox.com/s/b68u0dyyqqfysg1/Screenshot%202016-01-30%2010.47.37.png?dl=0
Moon is not always shown.. it is hard to find moon.
And it is problem of the mod using incompatible methods.
How would one change the length of the lunar cycle then? I like this mod, but, currently, I need the lunar cycle to be roughly as long as the vanilla one, due to compatibility issues with other mods (witchery and hardcore darkness). Is such a config setting planned, since it does not exist yet?
And how feasible would it be to pull off even, due to the amount of calculations and such that went into this mod?
Edit 1: So I'm finding out about the Calendar API, maybe I can get the devs of both mods to use it for their 1.7.10 builds.
@Abastro And it is problem of the mod using incompatible methods?
Clarify please?
@OreCruncher Dont use getCurrentMoonPhaseFactorBody, it is more incompatible. getCurrentMoonPhaseFactor or getMoonPhase is much better.
@Sunconure11 The moon cycle shouldn't be artificially tied to vanilla like that. The moon orbits the earth IRL, and the earth orbits the sun IRL… and this mod follows that, not mojang. If you want to customize your solar system (and the moon)… I believe that's what Stellarium is for.
My mod is calling world.getCurrentMoonPhaseFactor() to get the moons brightness already, so I am not sure what you are seeing/thinking.
@OreCruncher He might be thinking you're the author for the other mod called Hardcore Darkness, which uses getCurrentMoonPhaseFactorBody()
OK - no worries. Just want to make sure I wasn't doing something boneheaded. :)
Anyway changing lunar cycle cannot be solution for this.