MinecraftModDevelopmentMods/StellarSky

Compatibility with Hardcore Darkness by lumien

Sunconure11 opened this issue · 5 comments

Sunconure11 commented

How do I make this mod work properly with Hardcore Darkness mod? Hardcore Darkness makes it brighter at night when the moon is full, but it doesn't work properly when Stellar Sky is installed, because the moon's phases are different than Vanilla's moon phases.

lumien231/Hardcore-Darkness#13 (comment)

lumien231 commented

Would switching from World.getCurrentMoonPhaseFactorBody to World.getCurrentMoonPhaseFactor yield a actually functional method?

Abastro commented

@lumien231 It allows more compatibility.

Abastro commented

It would fixed on the latest version(v0.1.20).

Biochao commented

Just tested this on Stellar Sky version 0.5.5.1.7 and Hardcore Darkness version 1.8 on Minecraft 1.10 and no matter the hardcore darkness mode the night is bright.
Removing Stellar Sky lets hardcore darkness work in config modes 0 and 2

Abastro commented

@Biochao It is impossible for Stellar Sky to support that part.
There is a config optioon in Stellar Sky to control the brightness, it'll be in per-dimension settings.