X-RateLimit* headers should be optional

Question

X-RateLimit* headers should be optional

ryan-barker-zefr opened this issue 3 years ago · 2 comments

Currently, WebhookClient::update0 requires 3 response headers to prevent a NPE.

X-RateLimit-Remaining
X-RateLimit-Limit
X-RateLimit-Reset-After

This causes NullPointerException when pointing to a mock discord server

Easiest solution is to provide a sensible default using response.header(key,value) instead of response.header(key)

Answer 1 · 2021-05-17T09:54:18.000Z

Your mock server should serve the rate limit headers. It is not the job of the library to mock your rate limits for you.

Answer 2 · 2021-05-17T10:23:29.000Z

The NullPointerException wasn't really an issue but I removed it to make logs a little less frightening. This is addressed in 0.5.7 and the release should appear on maven central within the next hours.