Miss-Inputs/ROMniscience

Add option to view DS banner title/icon even if version is invalid

Miss-Inputs opened this issue · 1 comments

The secret real reason I'm giving myself this issue is so I can force myself to revamp the settings system, because we'll need to do that. The issue itself is self-explanatory.

But I'm thinking we'll need to do something like this:

In Handler.cs, have a virtual property customSettings that returns IDictionary<string, SettingType> where the key is the name and value is an enum that represents the type of the setting, or perhaps if I can just use classes I'll do that.

So for DS it'll return {"display invalid banner versions", bool} or something like that.

Then for SettingsDialog.cs in FolderEditor (let's change the name of that class btw) we'll need to make new form elements appear underneath the folder text box according to the handler's customSettings property, which you pass in to the FolderEditor constructor. Append those to settingsToSave accordingly.

I guess as far as actually storing the values goes, you'd have things like DS_display invalid banner versions as the key. That just means you won't be able to use "enabled" as a custom setting without things getting screwy, but why would you?

Anyway, I just thought that'd be a neat thing for debugging if there's some weird ROM which uses a different banner version but has a valid banner for some reason. I think it's safe to say all those banner versions of 46 aren't valid, though. Nor are the banners in the English Training demos. Or the Tetris DS: Push demo. Basically nothing I know of.