Some GCZ compressed discs don't load banner correctly
Miss-Inputs opened this issue · 1 comments
Shrek Superslam (USA) and Wind Waker (PAL) load the icon fine, but throw an ArgumentOutOfRangeException trying to decode the banner text.
Some others aren't able to load the icon at all, and throw an IndexOutOfRangeException trying to do so:
Metal Gear Solid: The Twin Snakes (USA) (both discs)
Super Smash Bros Melee (PAL), also 20XX 4.05
Pokemon Colosseum (PAL)
Sonic Heroes (USA)
Mega Man X Collection (USA)
Star Fox Adventures (USA) rev 1
F-Zero GX (USA)
Beyond Good & Evil (USA)
Pokemon XD (PAL)
Baten Kaitos (USA) disc 2 (disc 1 is fine, which is very odd)
Eternal Darkness: Sanity's Requiem (USA)
Pokemon Colosseum Bonus Disc (Japan)
Pokemon Channel (Australia)
With a bit of debugging, I ruled out the theory that some discs have two opening.bnr files with one in the wrong place or something annoying like that. I didn't think that would happen, but you never know. Anyway, I discovered this about Pokemon Channel (Australia) at least:
File offset is 759867712 (well within the boundaries of the disc, that's fine)
File length is 6496
The banner we read as a byte array has a length of 5824
Yeah, that last part might be a problem, eh?