MoArtis/RCGMod

Ribbon Bra hint

Alua7 opened this issue · 5 comments

Alua7 commented

It seems like Ribbon Bra still not matching its description. Can its hint be changed to actual "100% (not 10%) chance to get 2 items from vending machines and crates". Hope this item they will not fix 🥇

Let me check the code. That sounds easy to check.

image
Apparently they are testing for the wrong effect. And they just test if it is equipped or not. 🤔

Apparently it is a misconfiguration issue after they changed the EquipEffect enum. The item is also using that reflect1Damage thing.
And again it never test for a chance to apply the effect so it is always in effect.
I will just override the translation using the mod's data to say 100% instead of 10%.
image

image
image

Alua7 commented

And special thanks for adding json support so I could fix some localization's errors for my language <3