Improve Code Quality
mschoema opened this issue · 3 comments
The functions tpointseqarr_stbox and tnpointseqarr_stbox do the exact same thing and could be merged into a single function.
MobilityDB/src/point/tpoint_boxops.c
Lines 182 to 192 in d4ca7ec
MobilityDB/src/npoint/tnpoint_boxops.c
Lines 174 to 184 in d4ca7ec
This might be possible with other functions, but I didn't check that yet.
Uniformize the *_make_free functions.
MobilityDB/src/general/tinstantset.c
Lines 200 to 207 in f4f8257
MobilityDB/src/general/tsequence.c
Lines 718 to 722 in f4f8257
MobilityDB/src/general/tsequenceset.c
Lines 194 to 201 in f4f8257
The definition of the function tinstant_to_tinstantset in tinstant.h is a copy of the one in tinstantset.h and should be removed.
MobilityDB/include/general/tinstant.h
Line 81 in d4ca7ec
MobilityDB/include/general/tinstantset.h
Line 93 in d4ca7ec
Solved by PR #201