Hero Vision Desync on Respawn
Closed this issue · 1 comments
Sometimes when a hero dies, their vision becomes 'desynchronized' with the hero. The hero can still 'seemingly' uncover fog of war normally because the surrounding terrain lights up, but any enemies or items that would be revealed by that vision are now 'invisible' (client still considers them to be under fog of war). This seems to happen after a hero respawns.
This bug started after 7.20
Can't reliably reproduce under a fixed set of conditions, except it is common after 20-25 minutes in game
In this image, a super rare item has dropped as indicated by the particles, but the hero can not reveal the item's actual ground model and therefore can't click on it to pick it up! Enemy creeps will also be 'invisible' but can still attack and be attacked.
Leading Theory:
Running an entity report after a long game of Roshpit Champions shows that "npc_dota_thinker" seems to keep building up. Thinkers are created by data driven abilities either in the KV or with the script function ApplyDataDrivenThinker()
Please check your entity cleanup code and make sure all types of entities are being properly removed. If I UTIL_remove a unit, are all of his abilities, wearables, particles, modifiers, thinkers etc getting cleaned up properly? When a thinker expires, is it being fully removed?
solved, too many thinkers on map. Now clean up all thinkers by attaching thinkers handle to a variable and destroying it after a timer.
There is some problem with thinker cleanup then, starting at 7.20