issue with sv_importance function
Closed this issue · 4 comments
ferrenlove commented
Hi,
I am running you code and run into below error:
shapviz::sv_importance(shp)
Error in FUN(newX[, i], ...) : unused argument (simplify = FALSE)
Can you please help?
mayer79 commented
Yes. Either update R or shapviz, see #29
In the original version of sv_importance()
, we were using the new (and super useful) simplify
argument of apply()
. To make things run also for older R versions, this was replaced.
ferrenlove commented
Thank you! Let me try it and let you know!
On Fri, May 12, 2023 at 10:58 PM Michael Mayer ***@***.***> wrote:
Yes. Either update R or shapviz, see #29
<#29>
In the original version of sv_importance(), we were using the new (and
super useful) simplify argument of apply(). To make things run also for
older R versions, this was replaced.
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHMDKLFTYLX6NR3CCLTBYSDXF4PKFANCNFSM6AAAAAAYAJEBLU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Sincerely,
Xue Liu (Sheryl)
ferrenlove commented
It is good now!
Thank you so much for creating such a good package!
In my case, it creates better visualization than h2o default shap view!!
Much easier to detect the relationship!!!
On Fri, May 12, 2023 at 11:00 PM Xue Liu ***@***.***>
wrote:
… Thank you! Let me try it and let you know!
On Fri, May 12, 2023 at 10:58 PM Michael Mayer ***@***.***>
wrote:
> Yes. Either update R or shapviz, see #29
> <#29>
>
> In the original version of sv_importance(), we were using the new (and
> super useful) simplify argument of apply(). To make things run also for
> older R versions, this was replaced.
>
> —
> Reply to this email directly, view it on GitHub
> <#87 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHMDKLFTYLX6NR3CCLTBYSDXF4PKFANCNFSM6AAAAAAYAJEBLU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
Sincerely,
Xue Liu (Sheryl)
--
Sincerely,
Xue Liu (Sheryl)
mayer79 commented
Thanks for this feedback!