Modernizr/gulp-modernizr

feedback

sindresorhus opened this issue 11 years ago · 1 comments

sindresorhus commented 11 years ago

use through2 (we switched since through isn't using streams2) (example: https://github.com/sindresorhus/gulp-jscs/blob/master/index.js)
this should be opt.uglify = false;
you need to pass the files through: https://github.com/doctyper/gulp-modernizr/blob/develop/index.js#L62 so not to break the chain

Otherwise looks good to me. Nice job :)

doctyper commented 11 years ago

Thanks for taking a look!