Modernizr/gulp-modernizr

gulp-modernizr uses old modernizr metadata api

Closed this issue · 7 comments

mahnunchik commented

Hi,

Since this commit Modernizr/Modernizr@b8290c6 Modernizr exposes another metadata api.

In its current state gulp-modernizr is completely broken.

mahnunchik commented

This issue is more addressed to the https://github.com/doctyper/customizr

adammockor commented

This log is probably related.

16:33:31] Starting 'modernizr'...

Error: Cannot find module 'file'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Users/adam/Praca/temp/1.2.0/node_modules/gulp-modernizr/node_modules/customizr/node_modules/modernizr/lib/metadata.js:2:12)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Users/adam/Praca/temp/1.2.0/node_modules/gulp-modernizr/node_modules/customizr/node_modules/modernizr/lib/cli.js:5:13)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
mahnunchik commented

@adammockor it is more related to @Modernizr itself, it has file only in dev dependancies.

gulp-responsive uses metadata API of Modernizr which requires file module.

adammockor commented

So, it's not related to your issue? I am confused.

mahnunchik commented

@doctyper is in https://github.com/Modernizr org, so I think he can fix both repositories.

doctyper commented

This issue is being worked on here: https://github.com/doctyper/customizr/tree/feature/new-build-system
There is an open ticket in Modernizr/customizr#9. Please track your issues there.