MontFerret/ferret

Panic on "ignore.resources"

ziflex opened this issue · 5 comments

ziflex commented 
LET page = DOCUMENT("YOUR_URL", {
	driver: "cdp",
	ignore: {
        resources: [
            {
                url: "*",
                type: "image"
            }
        ]
    }
})
panakour commented

Is there any different from using disable.resources ?

LET doc = DOCUMENT("YOUR_URL", {
    driver: "cdp",
    disable: {
        resources: [
            {
                url: "*",
                type: "image"
            }
        ]
    }
})
ziflex commented

Hey,
I don't think we have "disable.resources".

panakour commented

Hi @ziflex,
what about this ?

ferret/examples/disable-images.fql

Line 3 in 60eae1a

disable: {
Is that wrong?

ziflex commented

Oh that one needs to be updated.

Here is the real code:
https://github.com/MontFerret/ferret/blob/master/pkg/stdlib/html/document.go#L208

panakour commented

thanks. I've opened a PR for this #625