Add Support To Install OpenJDK 17
Closed this issue · 13 comments
Require support to download/install OpenJDK 17.
UPDATE: Branch: features/issue_98_jdk_17_support
Build: https://static.moonshine-ide.com/downloads/msdki/branch/
We shall have this tested on branch for now.
AdopeOpenJDK 11 link also replaced with Temurin's based on the suggestion.
I did some testing for this:
| SDK | Already Installed | Install Status | Install Works |
|---|---|---|---|
| JDK 17 | No | Needs Installation | Yes |
| JDK 17 | Yes | Installed | N/A |
| JDK 11 | No | Needs Installation | Yes |
| JDK 11 | Yes | Installed | N/A |
| JDK 11 | AdoptOpenJdK version | Needs Installation | Yes |
I'd like to see some similar Windows tests. @JesseProminic, can you help with this testing?
The branch builds are available here: https://static.moonshine-ide.com/downloads/msdki/branch/
@JustinProminic reported that the ARM64/M1 Macs require a different version of JDK 17: https://adoptium.net/temurin/releases/?version=17
MSDKI need to automatically detect this and install the correct version.
Unfortunately, there is no ARM64 version of JDK 8, so we'll need to work from the Vagrant instance in this case. This will be handled in separate issues.
Note that we have other problems with Moonshine on ARM64, which will be covered by other issues:
Updates:
- System architecture detection on macOS
- XML updated to accommodate
archvariant - Parsing updated
The JDK shall auto-selects between _x64 or _arm64:
However, during further tests I see an exception that possibly was existing for some time. I do not have any proper solution to this yet, and I'm looking into. But this could lead to a FeathersUI bug.
- Open Getting Started
- In 'By Feature' section try to change the dropdown for OpenJDK variants for a few time
- Change to 'By Software' tab
- Try to change the OpenJDK variant dropdown which trigger an exception [Bug] as following:
[Fault] exception, information=TypeError: Error #1009: Cannot access a property or method of a null object reference.
at moonshine.components.renderers::PackageRenderer/onItemBeingUpdated()[/Users/devsena/Documents/DevareaLocal/ProminicGIT/Moonshine-SDK-Installer/MoonshineSDKInstallerGUICore/src/moonshine/components/renderers/PackageRenderer.hx:198]
at flash.events::EventDispatcher/dispatchEventFunction()
at flash.events::EventDispatcher/dispatchEvent()
at moonshine.haxeScripts.valueObjects::ComponentVO/set_createdOn()[/Users/devsena/Documents/DevareaLocal/ProminicGIT/Moonshine-SDK-Installer/MoonshineSDKInstallerGUICore/src/moonshine/haxeScripts/valueObjects/ComponentVO.hx:226]
at moonshine.haxeScripts.valueObjects::ComponentVO/set_isAlreadyDownloaded()[/Users/devsena/Documents/DevareaLocal/ProminicGIT/Moonshine-SDK-Installer/MoonshineSDKInstallerGUICore/src/moonshine/haxeScripts/valueObjects/ComponentVO.hx:199]
For Windows
| SDK | Already Installed | Install Status | Install Works |
|---|---|---|---|
| JDK 17 | No | Needs Installation | ✅ |
| JDK 17 | Yes | Installed | N/A |
| JDK 11 | No | Needs Installation | ✅ |
| JDK 11 | Yes | Installed | N/A |
I am not sure where I can find AdoptOpenJdK version.
I have installed newest nightly build (417) for Mac. I don't see on the list JDK 17 at all. Where it should be ?
@piotrzarzycki21 it's on branch. it's tagged 'on branch'.
However, during further tests I see an exception that possibly was existing for some time. I do not have any proper solution to this yet, and I'm looking into. But this could lead to a FeathersUI bug.
- Open Getting Started
- In 'By Feature' section try to change the dropdown for OpenJDK variants for a few time
- Change to 'By Software' tab
- Try to change the OpenJDK variant dropdown which trigger an exception [Bug] as following:
This is fixed now and ready for a test in Moonshine branch build.
This issue is now merged into master.
JDK 11 was removed from MSDKI after discussion here
We have some remaining questions for the Moonshine-side updates, but we'll discuss that here.