MoreMcmeta/emissive-plugin

End portal tiles render incorrectly when Iris shaders are enabled and MoreMcmeta's emissive plugin is loaded

Closed this issue · 3 comments

Describe the bug
End portal tiles render incorrectly when Iris shaders are enabled (Rethinking Voxels and BSL were both used for testing) and MoreMcmeta's emissive plugin is enabled in the mods list.
Each tile renders the current end portal texture individually per tile in a uniform direction on each one.

To reproduce
1. Install Iris (and any required mods), MoreMcmeta and emissive plugin
2. Install a resource pack that changes the end portal texture and a shader for Iris
3. Activate an end portal (create one in a creative world for easier testing) and look at the texture with shaders on.
4. Repeat the process with and without the emissive plugin enabled and see the difference.

Expected behavior
End portal textures rendering as they usually do with shaders.

Screenshots or videos
Shaders enabled with the emissive plugin disabled
shaders with no emissive plugin

Shaders with emissive plugin enabled
shaders with emissive plugin 1
shaders with emissive plugin 2

Emissive plugin enabled with shaders disabled
(for reference to show it only happens when the shaders + emissive plugin enabled)
portal without shaders

Which Minecraft versions does this bug affect?
1.20.2

Mod loader
Which mod loaders does this bug affect?

  • Forge
  • Fabric
    Forge was not tested.

Mods list
cloth-config-12.0.111-fabric
emissive-plugin-1.20.2-2.0.3-fabric.jar
fabric-api-0.90.7+1.20.2
fabric-language-kotlin-1.10.14+kotlin.1.9.20
ferritecore-6.0.1-fabric
indium-1.0.27+mc1.20.1
iris-mc1.20.2-1.6.10
lithium-fabric-mc1.20.2-0.12.0
modmenu-8.0.0
moremcmeta-1.20.2-4.4.1-fabric
sodium-extra-0.5.3+mc1.20.2-build.114
sodium-fabric-mc1.20.2-0.5.3

Resource pack
Nyan Cat End Portal (Colored Version)
https://www.planetminecraft.com/texture-pack/nyan-cat-end-portal/

Shader
Rethinking Voxels: https://modrinth.com/shader/rethinking-voxels
BSL: https://modrinth.com/shader/bsl-shaders
(I tried more than one to make sure it wasn't RVX causing the issue specifically)

Additional context
I created a fresh instance with only those mods and just the Nyan Cat resource pack to make sure none of my normal mods and resource packs may have been interfering. I was able to reproduce this issue with the more minimal set up described above.

soir20 commented

Thanks for reporting; I've identified the portion of the emissive plugin's code that causes the incompatibility. I have an idea to work around the issue. I'll do some testing to see if it works.

soir20 commented

MoreMcmeta emissive plugin v2.0.4, which contains a fix for this issue, has been released. It will take a few minutes for CurseForge to approve the files. Please report any issues you encounter with the new version.

Seems to be working fine now. 👍

2023-11-25_00 26 58

2023-11-25_00 26 47

Thank you!