MoriyaShiine/enchancement

some problems I found

Closed this issue · 5 comments

peow commented

Mod version (NOT Minecraft version)

Fabric v1.20-23

A description of the issue

  • 1) the texture of some mobs looks strange when they are frozen
    2024-04-18_10 12 55
    2024-04-18_10 15 40

  • 2) boots with the Buoy enchantment cannot descend when sneaking in water bubbles (from Soul Sand)

and if you are thrown up very quickly, when you fall into the water bubbles you will be taken down
2024-04-18_10 28 53
2024-04-18_10 28 54
2024-04-18_10 28 54_2
2024-04-18_10 28 54_3

  • 3) the mod is turning enchanted equipment into Epic Rarity instead of Rare and there is no option to disable this
    In Minecraft, enchanted items are considered "Rare" (https://minecraft.fandom.com/wiki/Rarity#Tiers) and I'm using a texture that makes the Tooltip of Rare items blue, and Epic items gold, but when using this mod the enchanted equipment becomes golden because of the rarity that has changed
    2024-04-13_16 19 17
    2024-04-13_16 20 58

Note that not only the tooltip has changed but also the color around the item, which the "Item Borders" mod adds, which follows the rarity of Minecraft Vanilla
without Enchancement the border is blue (Rare), with Enchancement the border is purple (Epic)

  • 4) this one is just a visual bug, when you bury a Shulker with the Bury enchantment, it no longer opens the shell when shooting

2024-04-18_10 26 45


If it is possible to fix these bugs, please publish a update to 1.20.1

Log or crash report

https://gist.github.com/peow/313aa1c7d3ff5e11936f2cec83f69ae3 in this log im not using the mod that shows the item rarity

  • 1: I'm unable to fix this, all Frostbite does is apply the ice texture to the model, but the model doesn't know which parts of which planes are transparent or not.
  • 2: The random descending happens with all non-water blocks and I'm not sure why, I still need to figure that out.
  • 3: This is intentional. Single Level Mode changes item rarity to indicate whether or not the enchanted item is strongly enchanted (epic) or weakly enchanted (rare).
  • 4: Interesting, I'll look into it.

Please open separate issues for 2 and 4

peow commented

3: the problem is, im not using the Single Level Mode

Okay then report that lol

peow commented

I forgot to specify this in the issue, but can this be fixed?

Yes, open an issue