MostroP2P/mostro

Adding orders doesn't work

Closed this issue ยท 13 comments

Testing on https://mostro.bilthon.dev
I created a test order, the event has been sent to 6/8 relays, but I cannot see it anywhere (checked also using a different account). I replicated this behavior a couple of times.

Hi @dtonon !

Thanks for your engagement first of all. We noticed sometimes this behaviour and we have to investigate, many times we suspect that relays are unresponsive or discarding for some weird reason events from Mostro, anyway usually it works.

@grunch setup a custom relay on wss://relay.mostro.network which should accept only event of kind 4 and 38383.

Feel free to test it and we will investigate, consider that we are basically only 3 people workin on mostro. Any help is appreaciated.

By the way we are from the same country and region, I know you from Nostr. ๐Ÿ˜„

I see that mostro.bilthon.dev is connected to relay.mostro.network, I just tested to create an order, in the console I see:

๐Ÿ“ก Event published to [6/8] relays

but the order is not present in the market dashboard.

By the way we are from the same country and region, I know you from Nostr. ๐Ÿ˜„

Oh, now I recognize you! :)

Hey @dtonon ,

i forgot to say that orders are limited between 100 and 20k sats of value.
Unluckily web dev still needs to implement a popup to signal this event. Maybe your orders were too big or too small?

They were about 17k sats (โ‚ฌ9).
I will try again, and post a video, maybe there is something else.

That's odd, I was just able to publish something. Which browser are you using? also did you check for any error logs in the console tab of the browser dev tools?

Macos / Chromium 123.0.6312.86 (Official Build, ungoogled-chromium) (arm64)

Screen.Recording.2024-07-02.at.22.38.58.mp4

@bilthon could be something related to the decimal input? I don't remember how it is managed.

@dtonon probably is the decimal digit, at the moment we want just to manage integers, @bilthon is introducing also range orders with ( like 10 -50 euros or others ), but I suppose that order is not created for the decimal digit.
Try with integers and in case confirm here that is working. We discussed with @grunch times ago about decimal and we did not implement them. @bilthon should fix the user interface to avoid inserting decimal values atm.

the decimal input?

After I posted I thought exactly that, but the event is actually created, maybe is it not somehow validated when pulled?

the decimal input?

After I posted I thought exactly that, but the event is actually created, maybe is it not somehow validated when pulled?

In the video i saw too the log of relay with 6/8 publishing, but in reality that message you're seeing above is a nip 4 message to mostro daemon that is not managing the event. Try with an order with integer you will see the broadcasted event from mostro to everybody coming after the dm nip 4

That's probably the culprit. I'll modify the form so that it rejects values with decimals in them.

I confirm that without decimal the order is created, sorry for not testing it at first.

I'll modify the form so that it rejects values with decimals in them.

It's fine for a quick fix, but finding the root cause might help in other areas, or reveal other related bugs. Just a suggestion :)

I confirm that without decimal the order is created, sorry for not testing it at first.

I'll modify the form so that it rejects values with decimals in them.

It's fine for a quick fix, but finding the root cause might help in other areas, or reveal other related bugs. Just a suggestion :)

the root cause is mostrod doesn't work with decimals so it rejects the new order from mostro-web, it's not bug but a feature ๐Ÿ˜…

I this is fixed on the new mostro web version, I'm closing this issue, if it's not fixed @bilthon let me know and I will re-open it again