MotocalDevelopers/motocal

expectedOugiGage is being calculated wrongly.

Closed this issue · 2 comments

in the following: (gobal_logic.js > calcBasedOneSummon > expectedOugiGage)
taRate * 37.0 + (1.0 - taRate) * daRate * 22.0 + (1.0 - daRate) * 10.0;
it does not take taRate for single attack. although it should.
for example if taRate is 100% it should "ignore" DA and likewise, SA.
should be like this:
taRate * 37.0 + (1.0 - taRate) * daRate * 22.0 + (1.0 - taRate) * (1.0 - daRate) * 10.0;

or
taRate * 37.0 + (1.0 - taRate) * (daRate * 22.0 + (1.0 - daRate) * 10.0);

Apologizes for this "mess". find it hard to explain.

One more thing, in case where expectedOugiGage is 0, expectedTurn would be dividing by 0 and resulting an "Infinity", and 'breaking' the results. This is possible by Charge Bar Speed UP being -100%.

Will get fixed. :)

I made tests for the proof
after #216 with #221 patch, expectedOugiGage and expectedTurn same to original formula.

https://codepen.io/anon/pen/eabywz?editors=0011