Mottie/GitHub-userscripts

(GitHub Toggle Expanders) Shift+Click (toggle all expanders within a date block) not working in repo commit pages

darkred opened this issue · 2 comments

darkred commented

Hi there @Mottie .

I've tried 'GitHub Toggle Expanders' in repository commit pages
and unfortunately Shift + Click (toggle all expanders within a date block, e.g. a commit in Dec 17, 2020) doesn't toggle any other expanders but the current one.
There's no error in Console.
(Ctrl + Shift + Click (toggle all expanders on the page) works fine).

Example pages:
https://github.com/mirror/jdownloader/commits/master
https://github.com/torvalds/linux/commits/master

Tested with Tampermonkey/Violentmonkey in Chrome/Firefox.

Also, in the script wiki it says:

  • Toggle expanders (…)
    • Use Shift + Click on an expander to toggle all expanders within a date block (New behavior in v2.0.0)
    • Use (Ctrl or ⌘) + Shift + Click on an expander to toggle all expanders on the page (New behavior in v2.0.0).

The accompanying GIF shows that Shift+Click expands all expanders in the page, not those within a date block.
So, the GIF depicts the pre v2.0.0 behavior. Could you please also update it?

Mottie commented

Thanks! It's fixed now.

  • 🎉1
darkred commented

Thanks a lot for the quick response!