Mottie/GitHub-userscripts

feature request? bug?: GitHub issue comments: support hiding linked commits

olets opened this issue · 5 comments

olets commented

I'd like to be able to hide linked commits in an issue's activity (e.g. in Issue 1, don't show commits with the message #1.

This fits in "GitHub issue comments".

Maybe this is a bug, and the "commits" toggle should be hiding them. Looking at the script I see that toggle is under "pull requests" so maybe the existing toggle isn't targeting issue pages and this is a feature request.

Thanks for all your work on these

Hi @olets!

I'm not sure I understand what you're asking. Do you mean when someone accidentally add #1 to a comment, you want to unlink it since it's not really a link? I'm not sure we can differentiate them from actual links to tickets?

olets commented

Nothing that complex. I mean hiding all commit references from the issue timeline.

Real life example: this issue has quite a few commits and one comment. Other concurrent work merged while this issue was worked on, and in this project's workflow we rebase and force-push branches when there's a change to the branch it'll merge into. On this project we include issue numbers in the commit messages. The result is a timeline item for each commit, and duplicative timeline items for each time the branch was force pushed. Not a good experience for the project manager who just wants to read the comments. It'd be great if the manager had the option of hiding all those commit references. "GitHub issue comments" seems like the answer!

Oh yes, the "commits" toggle should hide all those

olets commented

Hm good to know. It doesn't for me. Maybe I have a conflicting extension. Will look into it…

The previous screenshot was with commits toggled off. Doesn't seem to have found any:

image

olets commented

Haven't had a chance to debug my environment, but it sounds like this is probably user error. Will reopen if I find that it isn't