Add linting to help with JS style consistency

Question

Add linting to help with JS style consistency

Opened this issue 7 years ago · 4 comments

Answer 1 · 2017-07-31T07:52:50.000Z

Hey, can you share the linter/config you use? got a bit of PR waiting and as summer is there, I have a bit more time to clean them ;)

Answer 2 · 2017-08-07T17:39:19.000Z

Yes, it's all here: #47

Answer 3 · 2017-08-14T12:19:47.000Z

Hey,

I've tried to merge this into my branch and run eslint, but (on public), I have one error when running eslint manually:

5:5   error  'Sequelize' is assigned a value but never used  no-unused-vars

Which seems to be true, and probably a sign I am not using the right eslint or something is wrong somewhere.

$eslint -v
 v4.3.0

How am I supposed to do use it? is this supposed to be on git commit?

Answer 4 · 2017-08-14T14:57:34.000Z

Huh. The lint config at the HEAD of the linter branch has no-unused-vars set to 'warn' and package.json in that branch has eslint version at 4.4.0. So I'm not sure why you're getting error on no-unused-vars unless you're somehow running a different eslint config.