Mowmaster/Pedestals

material gen bug

Closed this issue · 4 comments

This is due to the fact that the requirements are written using MowLibs MowLibCompoundTagUtils, which for writeFluidStackToNBT (code here) only updates the tag if the stack is non-empty:

    public static CompoundTag writeFluidStackToNBT(String ModID, @Nullable CompoundTag inputNBT, FluidStack fluidStack, String identifier) {
        CompoundTag compound = inputNBT != null ? inputNBT : new CompoundTag();
        if (fluidStack.isEmpty()) {
            return compound;
        } else {
            compound.put(ModID + identifier, fluidStack.writeToNBT(new CompoundTag()));
            return compound;
        }
    }

So we either need to fully invalidate the stored recipe NBT from the compound tag in actionOnNeighborBelowChange, or update MowLib to have it remove the identifier from the compound when the stack is empty (or move off of the MowLib helpers for now).

As a workaround if anyone else is experiencing the issue, removing the upgrade would be sufficient to resolve the requirements (as actionOnRemovedFromPedestal resets the cached recipe completely).

Resolved with 4752639

released in this version: 1c83f56