MrAntares/roBrowserLegacy

Change Emblem = disconnection

Closed this issue · 7 comments

Describe the bug
Disconnection while trying to change the emblem:
[Warning]: clif_parse: Received packet 0x0153 with expected packet length 2457, but only 2048 bytes remaining, disconnecting session #9.

Screenshots (if applicable)
image

Packet/Client version
Packet/Client version 20130618

Browser/device info

  • Browser: Any
  • Device: Any

cant reproduce the issue, are u using the latest version?
as u can see in the following image i changed the emblem 5 times and it worked
can u send the emblem here?
also i'm using the same clientversion

image

image

It does work for me but not for the player who reported this to me and it isn't a cache issue as the player is new and I tested in incognito mode.
I think the player might play on Mac and might use Safari, I'll gather more information about this whenever I see the player online and report here.

Found the issue which is if the emblem has a bad format. Client will only trigger this error and not close the client but here browser disconnects the player as the client's behavior can't be reproduced at this stage.

image

test.zip
You can test with this to reproduce the bug.

image
The glitched emblem is because it uses 32 bit depth instead of 24 which then works.

Nice catch.
I will take a look if we can put in place a check so we don't get error, but really this is user error.

Added size check.
(Luckily the image must be a fixed size and BMP is fixed size per pixel per bit depth, so we can check size to see if it's more than 24 bit.)
image