MrOtherGuy/fx-autoconfig

Question about _ucUtils.windows.get(onlyBrowsers)

Mitezuss opened this issue · 3 comments

Mitezuss commented

You said:
Return a list of handles for each window for this firefox instance. If onlyBrowsers is false then this only includes browser windows (not consoles or similar). onlyBrowsers defaults to true.

And:

let windows = Services.wm.getEnumerator(onlyBrowsers ? 'navigator:browser' : null);

So, if onlyBrowsers is false, null is "only browser windows" ?

regards

MrOtherGuy commented

I think the readme is wrong. It looks like it should say something like "If onlyBrowsers is true then this only includes browser windows, if it's false then it also includes consoles, PiP, non-native notifications etc."

  • 👍1
Mitezuss commented

@MrOtherGuy

Yes i think so too.

MrOtherGuy commented

I've modified the readme to correct the description. Thanks for letting me know!